Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace incorrect expect calls with await in middleware e2es #267

Merged
merged 1 commit into from
Jan 20, 2025
Merged

replace incorrect expect calls with await in middleware e2es #267

merged 1 commit into from
Jan 20, 2025

Conversation

dario-piotrowicz
Copy link
Contributor

fixed #255

@dario-piotrowicz dario-piotrowicz requested a review from vicb January 20, 2025 10:37
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: fa1d9b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dario-piotrowicz dario-piotrowicz mentioned this pull request Jan 20, 2025
Open
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 20, 2025

Open in Stackblitz

pnpm add https://pkg.pr.new/@opennextjs/cloudflare@267

commit: fa1d9b9

vicb
vicb approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@vicb vicb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@dario-piotrowicz dario-piotrowicz merged commit 0b54cf4 into main Jan 20, 2025
7 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/255/add-awaits branch January 20, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vicb vicb vicb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e failing locally on chromium & webkit
2 participants
@dario-piotrowicz @vicb